add support for Laravel >= 9 dumpWithSource#94
Open
johanrosenson wants to merge 1 commit intobeyondcode:masterfrom
Open
add support for Laravel >= 9 dumpWithSource#94johanrosenson wants to merge 1 commit intobeyondcode:masterfrom
johanrosenson wants to merge 1 commit intobeyondcode:masterfrom
Conversation
johanrosenson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel 9 added source file & line number laravel/framework#44211 to the dump/dd output, but laravel-dump-server is not compatible with this feature.
The goal of this PR is to fix this by using Laravels dumper as fallback if the dump-server is not running.
This PR should not introduce any breaking changes and it also keeps support for older Laravel versions.
before this PR
after this PR