Fully support RFC8950 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements RFC 8950 "Advertising IPv4 Network Layer Reachability Information (NLRI) with an IPv6 Next Hop" to enable parsing of VPN-IPv4 routes with VPN-IPv6 next-hops. Changes include: - Extended Safi enum with MplsVpn (128) and MulticastVpn (129) for VPN address families - Added RouteDistinguisher type for 8-byte VPN route distinguisher parsing - Extended NextHopAddress enum with VpnIpv6 and VpnIpv6LinkLocal variants - Updated parse_mp_next_hop to handle 24-byte and 48-byte VPN next-hops: * 24 bytes: 8-byte RD + 16-byte IPv6 (VPN-IPv6 next hop) * 48 bytes: 8-byte RD + 16-byte IPv6 + 8-byte RD + 16-byte IPv6 link-local - Updated all exhaustive pattern matches to handle new NextHopAddress variants - Added comprehensive tests for VPN next-hop parsing and encoding - Updated documentation to mark RFC 8950 as supported This implementation is fully backward compatible and enables parsing of previously unsupported VPN next-hop formats per RFC 8950 Section 4.
Implements RFC 8950 Section 3 Extended Next Hop capability negotiation for BGP OPEN messages. This enables BGP speakers to advertise their ability to receive IPv4 NLRI with IPv6 next-hops and other cross-protocol combinations. Key features: - ExtendedNextHopCapability struct with parsing/encoding support - Integration with BGP OPEN message capability parsing infrastructure - Comprehensive validation and error handling with fallback to raw bytes - Helper methods: supports() and supported_nlri_for_nexthop() - Full test coverage including round-trip and integration tests Changes: - Add ExtendedNextHopCapability and ExtendedNextHopEntry structs - Extend CapabilityValue enum to support structured capability parsing - Update BGP capability parsing to handle Extended Next Hop capabilities - Add 8 comprehensive test cases covering all functionality - Maintain backward compatibility with existing capability parsing RFC 8950 compliance: - Supports arbitrary AFI/SAFI combinations per specification - Validates 6-byte entry format (AFI + SAFI + AFI) - Handles SAFI encoding differences (2 bytes in capability vs 1 byte normally)
…tion Documents the RFC 8950 Extended Next Hop capability parsing and encoding feature added in the previous commit, including structured capability parsing, BGP OPEN message integration, and comprehensive validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.