Better BGP error handling #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive BGP validation warning system that implements RFC 7606 revised error handling for BGP UPDATE messages. This ensures the parser never breaks from reading incorrect BGP messages and follows the treat-as-withdraw approach for mandatory attributes and attribute discard approach for optional attributes. Changes: - Add BgpValidationWarning enum with 12 warning types covering RFC 4271/7606 scenarios - Add validation_warnings field to Attributes struct with accessor methods - Implement attribute validation during parsing (flags, length, duplicates, missing mandatory) - Add RFC 7606 compliant error handling that continues parsing without session reset - Add conditional compilation guards for parser-only features - Add comprehensive tests for all RFC 7606 error handling scenarios - Add RFC 7606 to supported RFCs list in documentation - Use debug\! level logging for warnings to avoid output by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.