feat: add fallible iterator implementations for explicit error handling #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements fallible iterators that expose parsing errors to users, addressing the current limitation where errors are silently skipped and only logged as warnings.
New Features:
FallibleRecordIterator- ReturnsResult<MrtRecord, ParserErrorWithBytes>instead of skipping errorsFallibleElemIterator- ReturnsResult<BgpElem, ParserErrorWithBytes>instead of skipping errorsinto_fallible_record_iter()andinto_fallible_elem_iter()methods onBgpkitParserKey Benefits:
Module Reorganization:
itersmodule withdefaultandfalliblesubmodulesiters/mod.rsTest Plan
examples/fallible_parsing.rs)Usage Example
Backward Compatibility
✅ No breaking changes - all existing APIs remain unchanged
✅ Default behavior preserved - standard iterators continue to skip errors
✅ Additive only - new functionality is opt-in via new methods