feat: add RFC 6397 MRT geo-location extensions support #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GEO_PEER_TABLE subtype parsing and encoding - Implement GeoPeer and GeoPeerTable data structures - Support WGS84 coordinates with NaN for privacy protection - Add tests for parsing and round-trip encoding - Update documentation to mark RFC 6397 as supported
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage ? 89.79%
=======================================
Files ? 75
Lines ? 10099
Branches ? 0
=======================================
Hits ? 9068
Misses ? 1031
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Move encode() implementation from models to parser module - Consistent with PeerIndexTable and RibAfiEntries pattern - Remove feature gate as bytes is always available in parser - Move encoding test to parser module - Fixes build with --no-default-features
- Add MrtMessage::encode() test for GeoPeerTable encoding path - Add GeoPeerTable parsing test for TABLE_DUMP_V2 dispatcher - Fix unsupported type test to use correct RibGeneric subtypes - Add Peer::new() variation tests for all IPv4/IPv6 and 16/32-bit AS combinations - Update changelog to reflect simplified GeoPeer structure and test count - Improves test coverage for previously untested code paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implementation Details
Data Structures
GeoPeer: Contains peer information with latitude/longitude coordinatesGeoPeerTable: Complete geo-location table with collector coordinates and peer listFeatures
Eqimplementations to handle float fieldsTesting
Test Plan
cargo test- all tests passcargo clippy --all-features -- -D warnings- no warningscargo fmt- code formatted