Add RFC 8955/8956 BGP Flow Specification parsing support #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements Flow-Spec NLRI parsing and extended communities support following RFC 8955 (IPv4 Flow-Spec), RFC 8956 (IPv6 Flow-Spec), and RFC 9117 (Flow-Spec validation procedures). Key additions: - FlowSpecNlri data structure with 13 component types - Numeric and bitmask operators for traffic matching rules - Flow-Spec Extended Communities (rate limiting, marking, redirect) - IPv6-specific Flow-Spec components with prefix offset support - SAFI 133 (Flow-Spec) and SAFI 134 (L3VPN Flow-Spec) definitions - Custom Eq implementation for f32-containing types using bit comparison - Integration with existing NLRI and BGP attribute parsing The implementation focuses on data structure representation and parsing without packet evaluation logic, making it suitable for BGP message processing and analysis tools. All 22 Flow-Spec tests pass and BGP attributes maintain HashMap/HashSet compatibility through proper Eq trait implementation.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 89.79% 90.37% +0.58%
==========================================
Files 75 79 +4
Lines 10099 11654 +1555
==========================================
+ Hits 9068 10532 +1464
- Misses 1031 1122 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add 32 additional unit tests to improve test coverage for Flow-Spec implementation, focusing on previously uncovered code paths: - FlowSpecComponent methods and type classification - FlowSpecNlri IPv4/IPv6 detection and component validation - FlowSpecError Display implementation and error handling - Numeric/bitmask operator creation with various value lengths - Operator byte encoding/decoding edge cases - NLRI parsing error conditions and boundary cases Total Flow-Spec tests increased from 22 to 54, providing comprehensive coverage of public APIs, error conditions, and edge cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements BGP Flow Specification (Flow-Spec) parsing support following RFC 8955 (IPv4 Flow-Spec), RFC 8956 (IPv6 Flow-Spec), and RFC 9117 (Flow-Spec validation procedures).
The implementation focuses on data structure representation and parsing without packet evaluation logic, making it suitable for BGP message processing and analysis tools.
Test plan