Skip to content

Conversation

@hiroshisuga
Copy link
Contributor

What does this PR do?

Adds a translation of the locale ja.

Closes Issue(s)

Closes #

Motivation

Is it the correct way to add a translation? Hopefully more locales will be added to the branch for v3.0

@welcome
Copy link

welcome bot commented Mar 16, 2025

Thank you for this contribution! Could you please confirm if you already sent in the signed Contributor License Agreement? See https://docs.bigbluebutton.org/support/faq.html#why-do-i-need-to-sign-a-contributor-license-agreement-to-contribute-source-code Thanks in advance!

@GuiLeme
Copy link
Collaborator

GuiLeme commented Apr 2, 2025

Hello, @hiroshisuga thank you for the contribution, that is correct! But unfortunately we are not currently doing locales yet for this plugin. I will add this feature soon enough, though, and this PR will gladly make a great difference here! Thanks again and I'll keep you up to date.

@antobinary
Copy link
Member

Hi! In the community call yesterday a request for German translation was voiced too. @GuiLeme are we happy enough with the localization (via PRs) for any of the plugins? Perhaps we could mimic here what we do in bigbluebutton/bbb-plugin-tour#6

@GuiLeme
Copy link
Collaborator

GuiLeme commented Apr 2, 2025

@antobinary The thing is: we didn't have a pattern to follow before, but now, we are defining it as we can see here: bigbluebutton/plugin-typed-captions#8.

So I think we should try to stick with this pattern quoted above which follows what we do in BBB core. But that's definitely a good discussion

@antobinary
Copy link
Member

Thank you @GuiLeme ! I see #39

@antobinary antobinary changed the base branch from v3.1.x-release to v0.1.x April 17, 2025 16:52
@antobinary
Copy link
Member

Hi @hiroshisuga
We've added localization to the v0.0.x branch. Would you like to point these changes to that branch instead?

@hiroshisuga
Copy link
Contributor Author

Hi @antobinary ,
Sure, see #50 .

@antobinary antobinary closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants