feat: Filter out users with bot flag #80
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a filter to remove bots.
Closes Issue(s)
Closes #79
More
One thing to keep in mind:
The reason for this is that we are planning to change the subscription used to retrieve all users. At the moment, we rely on a custom subscription that isn’t reused anywhere else. The idea is that once this PR is merged — bigbluebutton/bigbluebutton#24213 — we will have all the necessary information to switch to the proper CORE hook (useUsersBasicInfo). This will allow us to reuse the subscription and improve overall performance.
Se demo below:
demo-filter-bot-pick-user.mp4