feat(plugins): Add support for the plugin to unmount on meeting end #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… decide whether to unmount on meeting end.
This was referenced Mar 12, 2025
JoVictorNunes
approved these changes
Mar 13, 2025
Collaborator
JoVictorNunes
left a comment
JoVictorNunes
left a comment
There was a problem hiding this comment.
The bug was fixed! LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR basically creates a way for the plugin to decide whether to unmount when the meeting is ended or the user is ejected.
Motivation
This PR fixes the problem where the pick-random-user modal continues open when meeting terminates (if it was open before).
A subsequent PR is going to be sent to the pick-random-user plugin repo implementing this function.
It's worth mentioning that if, for any reason, the plugin dev doesn't want to terminate the plugin once the meeting is over, that's still possible, once this function is not even mandatory.
How to test
Use this branch to test the pick-random-user:
More
Closely related to CORE PR bigbluebutton/bigbluebutton#22671
Closely related to Plugin PR: bigbluebutton/bbb-plugin-pick-random-user#31
See demo ahead:
fix_plugin_unmount.mp4