feat: Automatically sync sdk version in manifest.json #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anifest.json to new back-end validation
…ch others locales. (bigbluebutton#178)
…-data-hooks along with typos in the readme
…sdk-version-in-manifest
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new
postInstallscript to automatically sync themanifest.jsonplugin-sdk version with that of thepackage.json.Motivation
As we can see from the recent PR bigbluebutton/bigbluebutton#22986 adding validation in the back-end for the plugin-sdk version, we need to be consistent with the current specified plugin-sdk version in the
manifest.json, that's why the best alternative is to add a postInstall script to sync it everynpm installornpm ci.More
Again: Closely related to bigbluebutton/bigbluebutton#22986.