fix: fix useLocaleMessages and refactor useUiData #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates in ui-data hooks
JoVictorNunes
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It does 2 things:
useLocaleMessagesof not returning anything when the fallback locale fails to be fetched or parsed;useUiDatato not update its state when the content doesn't change - This lead to unnecessary fetches in theuseLocaleMessageshook;Closes Issue(s)
Closes #184
Motivation
Desired language was not being fetched when fallback locale file had a problem (even if the desired locale file was working properly).
More
Nothing to be changed in the CORE.