Skip to content

Conversation

@germanocaumo
Copy link
Contributor

What does this PR do?

Support svg icon in media area items like it is for action bar buttons (see #167)

Copy link
Collaborator

@GuiLeme GuiLeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine, I am just concerned about this being a breaking change. Since 3.1 has not been released yet, I'd say it's fine, but I'd feel more comfortable with a confirmation from your side that it would not be a problem. @Arthurk12, can you comment on this?

@Arthurk12
Copy link
Member

Thanks for pointing it out, @GuiLeme. We are aware that this modification is going to break the MediaAreaItems API.

For the future we could enhance and make the API consistent for all extensible areas by:

  1. Changing the icon argument from object to string | object;
  2. Allow SVG icons for all extensible areas as you pointed out here;

@GuiLeme
Copy link
Collaborator

GuiLeme commented Oct 8, 2025

@Arthurk12 sounds good, so let's maintain this PR as is and for the following one (adding SVG for all icons) we can do the strategy you brought up. That will be done likely in 0.0.x, but with the sync merge this will be resolved for 0.1.x as well.

@GuiLeme GuiLeme merged commit a6f4931 into bigbluebutton:v0.1.x Oct 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants