ref(plugin): refactor the code of plugin logger to be more robust #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o have more possibilities of configurations
|
This pull request has conflicts ☹ |
Arthurk12
reviewed
Nov 10, 2025
Member
Arthurk12
left a comment
Arthurk12
left a comment
There was a problem hiding this comment.
Nice, it works!
I added a few comments below and in the relative Core's PR for consideration.
… all methods to that defined by the pluginApi logger
Arthurk12
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It refactors the code for creating a pluginLogger, so now it will be set by the client and we have pretty much the same configurations as the main logger (being able to publish to external storage, configure log level and so on).
One other addition is that one can override the logging configuration per plugin.
Closes Issue(s)
Closes #231
How to test
In order to test it, I encourage you to try the
samples/sample-data-channel-plugin, there I introduced the new logger with the logging configuration set in the manifest (you can play around with the values.)More
It's worth mentioning that the name of the plugin is appended automatically into the logger, so that it's easily trackable.
Closely related to bigbluebutton/bigbluebutton#24185