feat(plugin): added z-index to floating-window #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It basically adds the z-index property into the floating-window constructor.
Closes Issue(s)
Closes #243
Motivation
When 2 floating windows overlap each other, the order of which comes on top was completely random. Now it's deterministic.
How to test
One can use the plugin-pin-message along with the reaction-stack to test: without the PR, if a message is pinned and a reaction is stacked, usually, the reaction comes on top of the pinned message. With this PR, the pinned message always comes on top.
More
Closely related to: bigbluebutton/bigbluebutton#24258
See demo below:
demo-zindex-floating-window.mp4