Skip to content

Conversation

@hipoloco
Copy link

@hipoloco hipoloco commented Dec 7, 2023

Apologies in advance if my english is not very good.

At my work we have implemented Apereo CAS (with OAuth 2.0 enabled) as SSO solution. When I tried to connect Greenlight with our SSO I encountered several problems, which I detail:

  • you can't use the discovery function (you need to set it to false).
  • it's necessary to set the host variable in the provider's client options
  • it's necessary to set the URIs of the endpoints (in particular, the user info endpoint)
  • the user data returned by our SSO has a structure that does not correspond to the one defined in the ./app/controllers/external_controller.rb file, in particular for the name and email fields:

Definition:

  • name: credentials['info']['name']
  • email: credentials['info']['email']

Definition required for Apereo CAS:

  • name: credentials['extra']['raw_info']]['attributes']['cn']
  • email: credentials['extra']['raw_info']['attributes']['mail']

This PR attempts to solve these problems by making the OIDC configuration more flexible.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant