3428 self request only default#3429
Closed
blister wants to merge 2 commits intobigskysoftware:devfrom
Closed
Conversation
Author
Collaborator
|
You may have had an issue between master and dev branch. I would recommend pulling the latest dev branch again and re-doing your one line change. you can either use some git wizardry to force push this change into this branch to fix this PR but it may be easier to close this one and start a new one if you have issues. |
Author
|
Closed (replaced with: #3435) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Code-comment mismatch for the default value of
selfRequestsOnlyconfig object option. It lists the default asfalse, but the actual default is defined astrue.Corresponding issue: #3428
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded