Skip to content

Conversation

@reez
Copy link
Collaborator

@reez reez commented Jul 1, 2025

Description

This should be the last Error needing to be removed from UDL in proc macro conversion.

Notes to the reviewers

I needed #791 merged before I did this, so I just merged 791 so this PR should be good to go now.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 528bc09

@reez reez merged commit 5e30cfa into bitcoindevkit:master Jul 7, 2025
24 checks passed
@reez reez deleted the mro5 branch July 7, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants