-
Notifications
You must be signed in to change notification settings - Fork 72
feat:tofu certificate validation #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lucasdbr05
wants to merge
5
commits into
bitcoindevkit:master
Choose a base branch
from
lucasdbr05:feat/TOFU-certificate-validation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+444
−14
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
219615c
feat: implement Trust On First Use (TOFU) for TLS connections
lucasdbr05 2cbc38a
test: add unit tests for TOFU certificate validation module
lucasdbr05 4004eed
refactor: convert TOFU to trait-based architecture
lucasdbr05 63beb8a
feat: integrate TOFU certificate validation into the main struct
lucasdbr05 9178ff9
docs: add TOFU certificate validation example
lucasdbr05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| extern crate electrum_client; | ||
|
|
||
| use electrum_client::{Client, ConfigBuilder, ElectrumApi, TofuStore}; | ||
| use std::collections::HashMap; | ||
| use std::sync::{Arc, Mutex}; | ||
|
|
||
| /// A simple in-memory implementation of TofuStore for demonstration purposes. | ||
| #[derive(Debug, Default)] | ||
| struct MyTofuStore { | ||
| certs: Mutex<HashMap<String, Vec<u8>>>, | ||
| } | ||
|
|
||
| impl TofuStore for MyTofuStore { | ||
| fn get_certificate( | ||
| &self, | ||
| host: &str, | ||
| ) -> Result<Option<Vec<u8>>, Box<dyn std::error::Error + Send + Sync>> { | ||
| let certs = self.certs.lock().unwrap(); | ||
| Ok(certs.get(host).cloned()) | ||
| } | ||
|
|
||
| fn set_certificate( | ||
| &self, | ||
| host: &str, | ||
| cert: Vec<u8>, | ||
| ) -> Result<(), Box<dyn std::error::Error + Send + Sync>> { | ||
| let mut certs = self.certs.lock().unwrap(); | ||
| certs.insert(host.to_string(), cert); | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| fn main() { | ||
| let store = Arc::new(MyTofuStore::default()); | ||
| let config = ConfigBuilder::new().tofu_store(store).build(); | ||
|
|
||
| let client = | ||
| Client::from_config("ssl://electrum.blockstream.info:50002", config).unwrap(); | ||
| let res = client.server_features(); | ||
| println!("{:#?}", res); | ||
| } | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned over at the issue, it would likely be preferable to add this via a separate constructor. Having an
Arc<dyn ..>in a config is rather odd, as it mixes code and data, basically.