Skip to content

[EPROD-1119] sync data from the evm canister in case no new blocks are generated from the primary url #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ufoscout merged 2 commits into from
Jan 31, 2025
Merged

[EPROD-1119] sync data from the evm canister in case no new blocks are generated from the primary url #57

ufoscout merged 2 commits into from
Jan 31, 2025

Conversation

@itsyaasir
Copy link

@itsyaasir itsyaasir commented Jan 23, 2025

No description provided.

@itsyaasir itsyaasir self-assigned this Jan 27, 2025
itsyaasir
itsyaasir commented Jan 27, 2025
View reviewed changes
ufoscout
ufoscout suggested changes Jan 27, 2025
View reviewed changes
Copy link

@ufoscout ufoscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Bitfinity - Tests github action should succeed

@itsyaasir
Copy link
Author

itsyaasir commented Jan 29, 2025 •
edited
Loading

@ufoscout The test is failing because getting the staging mode is not enabled for the current block extractors! hence returning an error! Here is a linked PR which tries to forward the calls to the EVM.

Does this mean we also need to add this endpoint to the reth to forward the calls to the evm ?

ufoscout
ufoscout suggested changes Jan 29, 2025
View reviewed changes
@itsyaasir itsyaasir force-pushed the EPROD-1119-sync-data-from-the-evm-canister-in-case-no-new-blocks-are-generated-from-the-first-url branch from f3c4d78 to b195861 Compare January 30, 2025 12:27
@itsyaasir itsyaasir marked this pull request as ready for review January 30, 2025 13:29
ufoscout
ufoscout suggested changes Jan 30, 2025
View reviewed changes
ufoscout
ufoscout suggested changes Jan 30, 2025
View reviewed changes
ufoscout
ufoscout reviewed Jan 30, 2025
View reviewed changes
ufoscout
ufoscout reviewed Jan 30, 2025
View reviewed changes
Copy link

@ufoscout ufoscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tests to be fixed:

ufoscout
ufoscout suggested changes Jan 30, 2025
View reviewed changes
Copy link

@ufoscout ufoscout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests to be fixed:

  1. commands::bitfinity_import_it::bitfinity_test_should_import_block_when_evm_is_enabled_and_check_evm_state_before_importing_is_false
  2. commands::bitfinity_import_it::bitfinity_test_should_import_blocks_when_evm_is_enabled_and_check_evm_state_before_importing_is_true

@itsyaasir itsyaasir force-pushed the EPROD-1119-sync-data-from-the-evm-canister-in-case-no-new-blocks-are-generated-from-the-first-url branch from 03e1935 to eebff62 Compare January 30, 2025 19:13
@ufoscout ufoscout merged commit c4b54ff into bitfinity-archive-node Jan 31, 2025
5 of 37 checks passed
@veeso veeso deleted the EPROD-1119-sync-data-from-the-evm-canister-in-case-no-new-blocks-are-generated-from-the-first-url branch January 31, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maximkaaa Maximkaaa Awaiting requested review from Maximkaaa

@veeso veeso Awaiting requested review from veeso

@F3kilo F3kilo Awaiting requested review from F3kilo

1 more reviewer

@ufoscout ufoscout ufoscout approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@itsyaasir itsyaasir

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsyaasir @ufoscout