Show only interval stats log during debug#94
Open
stiangrindvoll wants to merge 1 commit intobitly:masterfrom
Open
Show only interval stats log during debug#94stiangrindvoll wants to merge 1 commit intobitly:masterfrom
stiangrindvoll wants to merge 1 commit intobitly:masterfrom
Conversation
Displaying this log generates a lot of noise in centralized logging when using multiple instances of statsdaemon.
Contributor
|
I like to see this message in the logs, to know statsdaemon is working, and receiving roughly the correct volume of stats keys from applications ... but debug level logs every single individual stat, which is way too much. So I think what would be better is adding a log-level option, which could be [debug, info, warning, error], and you would probably prefer running at the "warning" level. |
Member
|
@ploxiln I also use these as a sort of canary, but I think there is a need for a better way to first-class healthcheck statsdaemon to know it's sending metrics. I'm not sure the best way for that, but if such a thing exists, then moving this log to debug (or other more granular logging selections) is fine by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Displaying this log generates a lot of noise in centralized logging when
using multiple instances of statsdaemon.
Also fits better to hide this in according with the -debug flag description.