fix: Improve CUDA version detection and error handling#1599
Merged
matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom Apr 17, 2025
Merged
fix: Improve CUDA version detection and error handling#1599matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom
matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
LGTM, thanks! We can merge after fixing the failing linter check. |
feaedbb
into
bitsandbytes-foundation:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Improve CUDA/HIP version detection and error handling
This commit fixes issue #1513 by improving the version detection logic
in cuda_specs.py to handle both CUDA and ROCm/HIP systems more robustly.
Key changes:
The changes ensure that:
Test results show successful version detection for both CUDA and ROCm/HIP
systems, resolving the original issue where torch.version.cuda.split()
would fail on ROCm systems.