Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GitHub Actions workflow for the Python package release process. The changes add steps to inspect directories, move and rename wheel files, delete an old pre-release release, generate a release body with pip install commands, and create a new pre-release artifact.
| echo "\`\`\`sh" >> body.md | ||
| echo "pip install $url" >> body.md | ||
| echo "\`\`\`" >> body.md | ||
| echo "" >> body.md |
There was a problem hiding this comment.
[nitpick] Consider refactoring the pip install command generation block by consolidating the multiple echo statements into a single heredoc or a separate script to improve readability and maintainability.
| echo "\`\`\`sh" >> body.md | |
| echo "pip install $url" >> body.md | |
| echo "\`\`\`" >> body.md | |
| echo "" >> body.md | |
| cat <<EOF >> body.md | |
| \`\`\`sh | |
| pip install $url | |
| \`\`\` | |
| EOF |
| uses: softprops/action-gh-release@v2.2.1 | ||
|
|
||
| - name: Delete old pre-release (if exists) | ||
| run: | |
There was a problem hiding this comment.
[nitpick] A brief inline comment explaining the use of '|| true' could help clarify that failing to delete a non-existent release is expected behavior.
| run: | | |
| run: | | |
| # Use '|| true' to ensure the script continues even if the release does not exist |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
1 participant
No description provided.