fix peft cpu ut failure#1765
Closed
yao-matrix wants to merge 4 commits intobitsandbytes-foundation:mainfrom
Closed
fix peft cpu ut failure#1765yao-matrix wants to merge 4 commits intobitsandbytes-foundation:mainfrom
yao-matrix wants to merge 4 commits intobitsandbytes-foundation:mainfrom
Conversation
Signed-off-by: Yao, Matrix <matrix.yao@intel.com>
Author
|
@matthewdouglas @jiqing-feng , pls help review and comment, thx very much. |
jiqing-feng
approved these changes
Sep 26, 2025
Member
|
Makes sense, thanks! Let's just fix the lint issue and we can merge it. Related issue: #1332 |
matthewdouglas
previously approved these changes
Sep 26, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Author
|
@matthewdouglas , fixed lint, thx very much. |
Member
|
Thanks @yao-matrix. I've taken this a little bit further in #1769 and will merge that instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in
toonlydataof param moved to the specified device, butSCBandCBstill keep in the before device, this will lead topeftbelow ut failSince in this code https://github.com/huggingface/peft/blob/main/src/peft/utils/integrations.py#L107, peft will find
weight.datahas different placement fromSCB, so kind of only partialtowas done.