Conversation
fix for windows
|
Hi, Can you please clarify what it is that is being fixed for Windows? What parts of unistd.h are actually needed? I assume this is for AMD GPUs on Windows, is that right? Preferably dependencies like #1834 and #1835 would be included in the same PR; but ideally I would not want to add any more code than necessary. |
|
Hi
/* Checking that we're on Windows */ #include <io.h> /* Access Constants (POSIX -> Windows) / /* Standard Descriptors */ /* #define access _access #ifdef _MSC_VER #ifdef __cplusplus #else #endif /* _UNISTD_H */ |
|
Is it even using anything in unistd.h? I created a PR to build for AMD on Windows and I just have it ignore that include, which builds and runs successfully. |
fix for windows