fix(java8): restore JDK 8 compatibility by removing Java 9–11 APIs #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mjwebblue
commented
Oct 23, 2025
mjwebblue
commented
- ContractLoader: replace Optional.isEmpty() with !isPresent().
- DocumentProcessingResult:
- replace List.copyOf(...) with new ArrayList<>(...) defensive copy.
- replace List.of() with Collections.emptyList().
- keep immutability via Collections.unmodifiableList(new ArrayList<>(...)).
- No behavioral changes; only API substitutions for JDK 8.
- ContractLoader: replace Optional.isEmpty() with !isPresent(). - DocumentProcessingResult: - replace List.copyOf(...) with new ArrayList<>(...) defensive copy. - replace List.of() with Collections.emptyList(). - keep immutability via Collections.unmodifiableList(new ArrayList<>(...)). - No behavioral changes; only API substitutions for JDK 8.
- Use Paths.get and Files.readAllBytes + StandardCharsets.UTF_8 in ContractMappingIntegrationTest. - Removes Java 11 APIs to restore test compilation on JDK 8. - No behavioral changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.