-
Notifications
You must be signed in to change notification settings - Fork 6
Bug: stats::lm() produces NA-containing ty. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… Better than just adding `na.rm = TRUE` to s = mean(tt) as it forces user to recheck their data.
…. is already invalid as it's trying to align a vector in a dimensional space smaller than the size of the dataset n. Instead B needs to be increased by doing more bootstrap replics (if possible).
…s run with a size of Y that means B*pct (approx)< n
Imat[Ij, ] seemed to be a mistake as the cols of Imat represent the m groups.
u. <- 2 * t. - s. gave a warning of different t. & s. lengths when applied to my data. Following "Estimation and Accuracy After Model Selection" by Efron, p995.
|
Additional commits to
|
bnaras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went over these changed files and am finding it difficult to distinguish the substantive changes from the non-substantive ones (such as indentation, new lines etc.) Could you please keep the original indentation? Thank you.
|
Please bear with me. Making a few corrections to my code so could be a few weeks before re-submission. |
Following Issue #4 this is a minimal bug correction to prevent a user running
bcajack2()if theirYchoice leads toB*pctapproximately being less than or equal tonakancol(Y).Otherwise
lm()will produce someNAentries inty.as there are insufficient observations (length(ip)) to solve the matrix equation inlm(), considering the number of dimensions ofxinlm()ispakancol(Y). Happy to explain further, as I'm aware my explanation is spread across this PR and Issue #4.