Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,42 @@ updates:
commit-message:
prefix: "chore(dependabot)"
prefix-development: "chore(dependabot)"
ignore:
# Ignore dependencies listed in the depcheck tool
#
# We do this to ensure that the versions are stable or manually updated for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I don't need this for V8: if a temporal_rs update needs an ICU4X udpate that's totally fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a more specific lists of which dependencies would be fine to push through one dependabot?

I thought I recalled that we'd talked at one point about not doing the updates. But the dependabot updates started stacking over the last month or so. I'd like to have a specific set that can be auto updated via dependabot and the rest that are set aside to be manually updated (hence the ignore section)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, in that way. Yeah I'd prefer if we supported as expansive a version of most deps as possible.

We are a library, dependabot does not actually serve a very strong purpose by updating versions in Cargo.toml. Users of this library can then pick the best versions.

I don't think we should use dependabot for automatic Cargo.toml bumps at all, unless it catches CVEs/etc.

What is it that dependabot gets us here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mainly gets us good version bumps for our tools, which is why I'd sort of like to keep them is to bump the tools to current while leaving the primary crates alone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with going to more expansive versions for this release if you're okay with it. I can adjust the Cargo.toml accordingly. I was debating doing just that, but thought I'd first start with the ignore list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, updating tools seems fine.

# V8 / Chrome
- dependency-name: "calendrical_calculations"
- dependency-name: "core_maths"
- dependency-name: "diplomat-runtime",
- dependency-name: "icu_calendar",
- dependency-name: "icu_calendar_data",
- dependency-name: "icu_collections",
- dependency-name: "icu_locale",
- dependency-name: "icu_locale_core",
- dependency-name: "icu_locale_data",
- dependency-name: "icu_provider",
- dependency-name: "ixdtf",
- dependency-name: "litemap",
- dependency-name: "potential_utf",
- dependency-name: "tinystr",
- dependency-name: "writeable",
- dependency-name: "yoke",
- dependency-name: "zerofrom",
- dependency-name: "zerotrie",
- dependency-name: "zerovec",
- dependency-name: "libm",
- dependency-name: "num-traits",
- dependency-name: "stable_deref_trait",
# Do not bump the compiled_deps either
- dependency-name: "bytes",
- dependency-name: "combine",
- dependency-name: "jiff-tzdb",
- dependency-name: "memchr",
- dependency-name: "tzif",

# Any of the dependencies listed above can be updated as need as they are Rust
# specific or dev-dependencies
groups:
rust-dependencies:
applies-to: version-updates
Expand Down
36 changes: 36 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,39 @@
## What's Changed in v0.2.0
* Fix incorrect decimal digits bug by @nekevss in [#679](https://github.com/boa-dev/temporal/pull/679)
* Update the documentation by @nekevss in [#680](https://github.com/boa-dev/temporal/pull/680)
* chore: cleanup zoneinfo_rs crate by @nekevss in [#674](https://github.com/boa-dev/temporal/pull/674)
* Test time zone canonicalization against ICU4X by @robertbastian in [#676](https://github.com/boa-dev/temporal/pull/676)
* Fix Sao Paulo bug in zoneinfo_rs by @nekevss in [#663](https://github.com/boa-dev/temporal/pull/663)
* Implement a zero copy tzdb provider by @nekevss in [#662](https://github.com/boa-dev/temporal/pull/662)
* Restrict the units that can be added to PlainYearMonth by @Manishearth in [#671](https://github.com/boa-dev/temporal/pull/671)
* Fix Duration out of bounds crash by @Manishearth in [#667](https://github.com/boa-dev/temporal/pull/667)
* Implement std::error::Error for TemporalError by @LeandroVandari in [#664](https://github.com/boa-dev/temporal/pull/664)
* Rebuild time zone data with 2025c by @nekevss in [#660](https://github.com/boa-dev/temporal/pull/660)
* Add support for time zone designations by @nekevss in [#659](https://github.com/boa-dev/temporal/pull/659)
* Fix bug in POSIX time zone calculations by @nekevss in [#658](https://github.com/boa-dev/temporal/pull/658)
* Add two different HostHook impls by @nekevss in [#591](https://github.com/boa-dev/temporal/pull/591)
* Add NonZeroSign type to ensure proper sign handling by @nekevss in [#652](https://github.com/boa-dev/temporal/pull/652)
* Update to new ComputeNudgeWindow spec text by @Manishearth in [#636](https://github.com/boa-dev/temporal/pull/636)
* Fix ZonedDateTime::with bug when empty fields is provided by @nekevss in [#650](https://github.com/boa-dev/temporal/pull/650)
* Add manual PartialOrd impl for FiniteF64 by @nekevss in [#649](https://github.com/boa-dev/temporal/pull/649)
* Correct sign in nudge_to_zoned_time by @catamorphism in [#647](https://github.com/boa-dev/temporal/pull/647)
* YearMonth addition: Use ISO parameters, not calendared parameters, when subtracting by @Manishearth in [#645](https://github.com/boa-dev/temporal/pull/645)
* Fix typo in doc string by @catamorphism in [#639](https://github.com/boa-dev/temporal/pull/639)
* Set YearMonth's day to 1 in calendar space when diffing by @Manishearth in [#640](https://github.com/boa-dev/temporal/pull/640)
* unify iso naming in `Now` by @Sharktheone in [#631](https://github.com/boa-dev/temporal/pull/631)
* Style updates by @Sharktheone in [#632](https://github.com/boa-dev/temporal/pull/632)
* Use all-features for timezone_provider on docs.rs by @Manishearth in [#630](https://github.com/boa-dev/temporal/pull/630)
* remove unneeded clone in TzdbResolver::get by @Sharktheone in [#628](https://github.com/boa-dev/temporal/pull/628)
* Attempt to handle the "completely contained within" timezone rule by @Manishearth in [#629](https://github.com/boa-dev/temporal/pull/629)
* Reject on empty fields object in PlainYearMonth::with by @nekevss in [#626](https://github.com/boa-dev/temporal/pull/626)

## New Contributors
* @robertbastian made their first contribution in [#676](https://github.com/boa-dev/temporal/pull/676)
* @LeandroVandari made their first contribution in [#664](https://github.com/boa-dev/temporal/pull/664)
* @catamorphism made their first contribution in [#647](https://github.com/boa-dev/temporal/pull/647)

**Full Changelog**: https://github.com/boa-dev/temporal/compare/v0.1.2...v0.2.0

# Changelog

All notable changes to this project will be documented in this file.
Expand Down
18 changes: 9 additions & 9 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ members = [

[workspace.package]
edition = "2021"
version = "0.1.2"
version = "0.2.0"
rust-version = "1.83.0"
authors = ["boa-dev"]
license = "MIT OR Apache-2.0"
Expand All @@ -29,9 +29,9 @@ exclude = [

[workspace.dependencies]
# Self
temporal_rs = { version = "0.1.2", path = ".", default-features = false }
timezone_provider = { version = "0.1.2", path = "./provider", default-features = false }
zoneinfo_rs = { version = "0.0.18", path = "./zoneinfo" }
temporal_rs = { version = "0.2.0", path = ".", default-features = false }
timezone_provider = { version = "0.2.0", path = "./provider", default-features = false }
zoneinfo_rs = { version = "0.1.0", path = "./zoneinfo", default-features = false }

# Dependencies
rustc-hash = "2.1.0"
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ foremost -- designed for use in ECMAScript implementations. This is not to detra
from temporal_rs's use in a native Rust program, but it is important information to
understand in order to understand the library's architecture and general API design.

Without default feature flags, temporal_rs does not have with access to the host
Without default feature flags, temporal_rs is not released with access to the host
environment and it does not embed any time zone data. This is important from an
interpreter perspective, because access to the host environment and time zone data
comes from the interpreter's agent, not from a dependency.
Expand Down
2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
//! from temporal_rs's use in a native Rust program, but it is important information to
//! understand in order to understand the library's architecture and general API design.
//!
//! Without default feature flags, temporal_rs does not have with access to the host
//! Without default feature flags, temporal_rs is not released with access to the host
//! environment and it does not embed any time zone data. This is important from an
//! interpreter perspective, because access to the host environment and time zone data
//! comes from the interpreter's agent, not from a dependency.
Expand Down
4 changes: 3 additions & 1 deletion tools/depcheck/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,10 @@ fn main() {
);
}

// NOTE: Please update .github/dependabot.yml if the below are
// altered in any way.

/// Dependencies that are always allowed as runtime dependencies
///
pub const BASIC_RUNTIME_DEPS: &[&str] = &[
// temporal_rs crates
"temporal_rs",
Expand Down
2 changes: 1 addition & 1 deletion zoneinfo/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "zoneinfo_rs"
description = "Zoneinfo parser and compiler"
edition.workspace = true
version = "0.0.18"
version = "0.1.0"
rust-version.workspace = true
authors.workspace = true
license.workspace = true
Expand Down