-
Notifications
You must be signed in to change notification settings - Fork 4
Test many different encodings #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test many different encodings #28
Conversation
|
This is interesting, even on Ubuntu in the CI we create a codec object for unsupported codecs: |
| @unittest.skipUnless(sys.platform.startswith("linux"), "Linux only test") | ||
| def test_encode(self): | ||
| bytestring = "Hallo".encode("T.61") | ||
| bytestring = "Hallo".encode("VISCII") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we switch, VISCII is not provided by CPython, and seems to be more cross-platform than T.61.
| try: | ||
| "a".encode(encoding) | ||
| except Exception as e: | ||
| raise AssertionError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use self.fail here as well?
No description provided.