Internalize dynamic expression parsing library#1
Closed
glopesdev wants to merge 3 commits intobonsai-rx:mainfrom
Closed
Internalize dynamic expression parsing library#1glopesdev wants to merge 3 commits intobonsai-rx:mainfrom
glopesdev wants to merge 3 commits intobonsai-rx:mainfrom
Conversation
We need to introduce small modifications to improve editing experience, but System.Linq.Dynamic has since been deprecated. Here we internalize the archived source to support these modifications.
glopesdev
force-pushed
the
internalize-dynamic-linq
branch
from
cfab443 to
b91bd82
Compare
Member
Author
|
Superseded by #2. We have chosen to move on from the legacy parsing library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to introduce small modifications to improve editing experience, but
System.Linq.Dynamichas since been deprecated. The replacement library is much more complex, and since we are looking to expand the capabilities beyond just LINQ expressions, we decided to internalize the archived source for now to support these modifications.The original distribution of
System.Linq.Dynamicis licensed under Ms-PL, which requires that source distributions preserve the original license. Binary distributions do not need this requirement. Therefore, we will keep the MIT license for the NuGet package distribution, and have added the Ms-PL license to the folder storing the internalized library copy.