Skip to content

Fix compilation on Windows with BOOST_PROCESS_STANDALONE defined #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwhitworth-vicon wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix compilation on Windows with BOOST_PROCESS_STANDALONE defined #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
147ebef
Fix the BOOST_PROCESS_V2_ASSIGN_LAST_ERROR macro when BOOST_PROCESS_S…
jwhitworth-vicon Dec 19, 2025
9f14a75
Remove spurious `v2::` namespace prefix in the Windows default_launch…
jwhitworth-vicon Dec 19, 2025
de69da2
Add missing `std::` namespace qualifier for `std::is_convertible` in …
jwhitworth-vicon Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions include/boost/process/v2/detail/config.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ using std::optional;

#define BOOST_PROCESS_V2_ASSIGN_EC(ec, ...) ec.assign(__VA_ARGS__);
#define BOOST_PROCESS_V2_ASSIGN_LAST_ERROR(ec) \
ec.assign(::BOOST_PROCESS_V2_NAMESPACE::detail::get_last_error()); \
do \
{ \
ec = ::BOOST_PROCESS_V2_NAMESPACE::detail::get_last_error(); \
} \
while (false)


#else
Expand Down Expand Up @@ -157,7 +161,7 @@ BOOST_PROCESS_V2_END_NAMESPACE
#define BOOST_DYN_LINK
#endif
#include <boost/config/auto_link.hpp>
#endif
#endif

#if defined(BOOST_PROCESS_V2_POSIX)

Expand Down
2 changes: 1 addition & 1 deletion include/boost/process/v2/process.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ struct basic_process
template <typename ExecutionContext>
explicit basic_process(ExecutionContext & context,
typename std::enable_if<
is_convertible<ExecutionContext&,
std::is_convertible<ExecutionContext&,
net::execution_context&>::value, void *>::type = nullptr)
: process_handle_(context.get_executor()) {}

Expand Down
2 changes: 1 addition & 1 deletion include/boost/process/v2/windows/default_launcher.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ struct default_launcher
auto proc = (*this)(context, ec, executable, std::forward<Args>(args), std::forward<Inits>(inits)...);

if (ec)
v2::detail::throw_error(ec, "default_launcher");
detail::throw_error(ec, "default_launcher");

return proc;
}
Expand Down