Skip to content

Trace logs to see where CI hangs #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Johan-Liebert1 wants to merge 1 commit into from
Closed

Trace logs to see where CI hangs #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/integration-tests/src/tests/run_ephemeral.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ fn test_run_ephemeral_with_instancetype() -> Result<()> {

let stdout = cmd!(
sh,
"{bck} ephemeral run --rm --label {label} --itype u1.micro --execute {script} {image}"
"{bck} ephemeral run --rm --label {label} --env RUST_LOG=trace --itype u1.micro --execute {script} {image}"
Copy link

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Enabling trace-level logging via RUST_LOG=trace is useful for debugging, but it will generate a large amount of log output. This should be removed before merging to avoid excessive noise in test logs.

Suggested change
"{bck} ephemeral run --rm --label {label} --env RUST_LOG=trace --itype u1.micro --execute {script} {image}"
{bck} ephemeral run --rm --label {label} --itype u1.micro --execute {script} {image}

)
.read()?;

Expand Down
2 changes: 1 addition & 1 deletion crates/kit/scripts/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -euo pipefail
set -xeuo pipefail
Copy link

@gemini-code-assist gemini-code-assist bot Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

The set -x option introduces a critical security vulnerability by printing all executed commands and their arguments, including sensitive information like passwords or API tokens, to standard error. This poses a significant risk in CI/CD environments where logs are persisted. Furthermore, set -x is overly verbose and not intended for permanent inclusion in production code.

Suggested change
set -xeuo pipefail
set -euo pipefail


SELFEXE=/run/selfexe

Expand Down