Open
Conversation
Signed-off-by: Peter Bynum <pkpbynum@gmail.com>
526cdf7 to
a3828ad
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces support for the --insecure-policy flag in skopeo, allowing users to disable signature verification. The changes include adding an insecure_policy field to the ImageProxyConfig struct, implementing the logic to pass this flag to the skopeo command, and adding a corresponding test case to ensure correct functionality. The implementation is clean and follows idiomatic Rust practices, particularly with the use of Option<bool> and unwrap_or_default() for handling the boolean flag. The new feature is well-integrated and tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports build environments that cannot supply a policy at the standard file paths (specifically nix). Eventually, I'd like this to also be consumed in composefs-rs such that we can produce composefs images at build time in the nix sandbox. In this environment, the hash of the build output is known & trusted before the image is fetched.