-
Notifications
You must be signed in to change notification settings - Fork 3
devenv: Add a c10s version #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the development environment by introducing a CentOS Stream 10 option, alongside the existing Debian setup. This change provides greater flexibility for developers, allowing them to choose their preferred Linux distribution for the development container. The underlying build system has been refactored to support these distinct environments, ensuring a clear separation and maintainability of dependencies and configurations for each base OS. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a CentOS Stream 10 version of the development environment, complementing the existing Debian-based one. The changes are well-structured, with new Containerfiles for each distribution and updated Justfile targets. My review includes a few suggestions to improve the shell scripting within the new container files for better maintainability and clarity.
Let's make this one a possible option too. Signed-off-by: Colin Walters <walters@verbum.org>
083fdbe to
5d12cd9
Compare
Let's make this one a possible option too.