Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
fail-fast: false
matrix:
ruby-version: [ '3.4', '3.3', '3.2', 'ruby-head' ]
gemfile: [ '7.2', '7.1', 'edge' ]
gemfile: [ '8.0', '7.2', '7.1', 'edge' ]
env:
BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
steps:
Expand Down
4 changes: 2 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ task default: %i[test rubocop:autocorrect]
namespace :test do
desc "Run tests for all supported Rails versions, with current Ruby version"
task :all do
original_directory = Dir.pwd
original_gemfile = ENV["BUNDLE_GEMFILE"]
gemfiles = Dir.glob("gemfiles/*.gemfile").reject { |f| File.basename(f) == "common.gemfile" }
gemfiles.each do |f|
Expand All @@ -41,13 +40,14 @@ namespace :test do
system("bundle exec rake test")
end

original_directory = Dir.pwd
Dir.chdir("demo")
ENV.delete("BUNDLE_GEMFILE")
system("bundle check") || system("bundle install")
system("bundle exec rake test:all")

ensure
original_gemfile.nil? ? ENV.delete("BUNDLE_GEMFILE") : ENV["BUNDLE_GEMFILE"] = original_gemfile
Dir.chdir(original_directory)
Dir.chdir(original_directory) unless original_directory.nil?
end
end
9 changes: 9 additions & 0 deletions gemfiles/8.0.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
gems = "#{__dir__}/common.gemfile"
eval File.read(gems), binding, gems # rubocop: disable Security/Eval

gem "bigdecimal" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
gem "drb" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
gem "mutex_m" if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("3.4.0")
gem "rails", "~> 8.0.0"
gem "sprockets-rails", require: "sprockets/railtie"
gem "sqlite3"
2 changes: 1 addition & 1 deletion lib/bootstrap_form/inputs/check_box.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def check_box_value(name, value)
# label's `for` attribute needs to match checkbox tag's id,
# IE sanitized value, IE
# https://github.com/rails/rails/blob/5-0-stable/actionview/lib/action_view/helpers/tags/base.rb#L123-L125
"#{name}_#{value.to_s.gsub(/\s/, '_').gsub(/[^-[[:word:]]]/, '').mb_chars.downcase}"
"#{name}_#{value.to_s.gsub(/\s/, '_').gsub(/[^-[[:word:]]]/, '').downcase}"
end

def check_box_classes(name, options)
Expand Down
Loading