Adding BioListener boards support#759
Merged
Andrey1994 merged 29 commits intobrainflow-dev:masterfrom Mar 10, 2025
Merged
Conversation
…c ADC type detection, conversion to microvolts
# Conflicts: # csharp_package/brainflow/brainflow/board_controller_library.cs # java_package/brainflow/src/main/java/brainflow/BoardIds.java # julia_package/brainflow/src/board_shim.jl # matlab_package/brainflow/BoardIds.m # nodejs_package/brainflow/brainflow.types.ts # python_package/brainflow/board_shim.py # rust_package/brainflow/src/ffi/constants.rs # src/board_controller/brainflow_boards.cpp # src/utils/inc/brainflow_constants.h
Member
|
thanks, I will review tomorrow |
Andrey1994
reviewed
Mar 6, 2025
Member
Andrey1994
left a comment
Andrey1994
left a comment
There was a problem hiding this comment.
looks great overall, thanks, wrote some comments, but nothing major, and especially thanks for emulator
…ded default values, minor fixes, docs updates
…ded default values, minor fixes, docs updates
Contributor
Author
|
Addressed review comments. Please review. Thanks! |
Andrey1994
approved these changes
Mar 9, 2025
Member
Andrey1994
left a comment
Andrey1994
left a comment
There was a problem hiding this comment.
looks good to me, will submit when CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BioListener is an open-source project designed to revolutionize biosensing with portable, affordable, multi-channel biosensing boards.
Project website: https://github.com/serhii-matsyshyn/biolistener
Here is the link to the image with a white background, square shaped for the BrainFlow website: https://live.staticflickr.com/65535/54361164718_e0031a3951_o.png
This PR includes 8-channel BioListener boards support.
Please note that PR #754 had broken multiple languages bindings support since board
OB3000with board number63was not added to all languages. Hence, this is fixed in this PR as well. In the future, such mistakes can have much worse consequences if not detected and corrected ASAP. A CI test implementation checking all the files updated in the correct way on new board addition is desirable; it can be added as an enhancement issue.