FEATURE: Select styles from a dropdown#9
FEATURE: Select styles from a dropdown#9Sebobo wants to merge 4 commits intobreadlesscode:masterfrom
Conversation
|
@Sebobo Is there a way to contribute to this draft PR, without merging it? |
|
@breadlesscode of course. I enabled "Allow edits from maintainers". You should simply be able to push to my branch. |
| onClick={this.handleClick} | ||
| title={i18nRegistry.translate(tooltip)} | ||
| /> | ||
| {isOpen ? ( |
There was a problem hiding this comment.
Why are you creating a group of SelectBoxes instead of a singel SelectBox? Is there a reason for that?
There was a problem hiding this comment.
This is for each Attribute (in the example above color and size). There can be multiple attributes/styles in one styling button.
|
When I created the first version for the customer they used multiple selectboxes. For example one for the font size, one for the style and one for the color. |
|
Any plans to merge this feature? Sounds very useful :) |
Sorry, much work here but no time. :( But you can help If you can 👍 |
Neos.Ui 3.7.0 includes more CK classes which can be used by plugins without causing CK to throw warnings of duplicate inclusions.
markusguenther
force-pushed
the
feature/dropdown-selection
branch
from
db0f472 to
611d3e3
Compare
|
Updated the PR but still needs to find out why the change of the dropdown does not apply. |
|
A working alternative: https://github.com/techdivision/ckstyles ;) I think they implemented the remove formatting better: |
6 participants
This change makes it possible to configure buttons which open
a dropdown with multiple styling selections.
With this multiple groups of styling options can be applied to a text selection.
Resolves: #2