This repository was archived by the owner on Dec 30, 2019. It is now read-only.
fix for cases where connection is broken and release() is called, avo…#118
Open
olgkpln wants to merge 2 commits intobrianc:masterfrom
Open
fix for cases where connection is broken and release() is called, avo…#118olgkpln wants to merge 2 commits intobrianc:masterfrom
olgkpln wants to merge 2 commits intobrianc:masterfrom
Conversation
…id returning the broken connection to the idle pool
Owner
|
Thanks for the pull request @olgkpln! Any way you could write a test for this? |
Contributor
|
I think #115 is a better way to prevent this or is there any other way then double releasing the client to trigger this bug? |
Owner
|
ah yeah if #115 fixes this I can just merge that one. |
Author
|
#115 is a good fix as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a case when release() is called for a broken connection. without this, the broken connection is returned to the idle pool and reused.