Implement sha512-256 and sha512-224#67
Open
ChALkeR wants to merge 3 commits intobrowserify:masterfrom
Open
Conversation
Older don't have sha512-256 and sha512-224, but they should get tested.
Contributor
Author
|
cc @dcousens |
|
ping @dcousens |
Member
|
LGTM, maybe @ForbesLindesay can merge it for you |
|
@ForbesLindesay does this PR also look good to you? |
|
@jprichardson @calvinmetcalf @fanatid any chance this PR has a viable path towards being merged? Or is it as dead as a doornail. |
|
. |
fanatid
reviewed
Feb 1, 2022
Contributor
fanatid
left a comment
fanatid
left a comment
There was a problem hiding this comment.
LGTM except for 1 comment about the test. I can merge it but only @calvinmetcalf can make npm release.
| tape("hash is the same as node's crypto for all algos provided by node", function (t) { | ||
| var hashes = crypto.getHashes() | ||
| Object.keys(sha).forEach(function (alg) { | ||
| if (hashes.indexOf(alg) === -1) return // skip unsupported by current Node.js version |
Contributor
There was a problem hiding this comment.
Do we really test newly added sha512-224 / sha512-256?
Contributor
Author
taimanhui
added a commit
to taimanhui/blockchain-libs
that referenced
this pull request
Mar 2, 2022
As crypto-browserify doesn't support sha512/256 yet. See browserify/sha.js#67
taimanhui
added a commit
to taimanhui/blockchain-libs
that referenced
this pull request
Mar 2, 2022
As crypto-browserify doesn't support sha512/256 yet. See browserify/sha.js#67
taimanhui
added a commit
to taimanhui/blockchain-libs
that referenced
this pull request
Mar 2, 2022
As crypto-browserify doesn't support sha512/256 yet. See browserify/sha.js#67
taimanhui
added a commit
to taimanhui/blockchain-libs
that referenced
this pull request
Mar 2, 2022
As crypto-browserify doesn't support sha512/256 yet. See browserify/sha.js#67
taimanhui
added a commit
to taimanhui/blockchain-libs
that referenced
this pull request
Mar 2, 2022
As crypto-browserify doesn't support sha512/256 yet. See browserify/sha.js#67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, the same relationship as between sha256 and sha224 -- I copied that approach.
Simple tests included that it matches Node.js impl, but there are no other test vectors due to test organization (vectors are in a separate package).