Skip to content

perf(bond-controller): consolidate loops, remove array allocation, gas optimization #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
craig-iam-smith wants to merge 5 commits into
base: main
Choose a base branch
from
Open

perf(bond-controller): consolidate loops, remove array allocation, gas optimization #53

craig-iam-smith wants to merge 5 commits into from

Conversation

@craig-iam-smith
Copy link

@craig-iam-smith craig-iam-smith commented Mar 19, 2023

Changes:

  • consolidate two loops in to one, all data is available and relevant in first pass
  • remove array allocation, it is unnecessary when using only one loop
  • less gas is used, and code is easier to understand

Test:

  • updated tests to pass with less gas being used

@craig-iam-smith craig-iam-smith marked this pull request as ready for review March 19, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@craig-iam-smith