fix: inline install script in Dockerfile and update image reference #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #50 - Remove dependency on deleted scripts/ directory by inlining wasmtime, cargo-component, and wkg installation in Dockerfile - Update devcontainer.json to reference the correct published image (bytecodealliance/sample-wasi-http-rust-devcontainer)
Collaborator
Author
|
Testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #50
The devcontainer publish workflow was failing because the Dockerfile referenced a
scripts/directory that was removed in #26.Changes
Dockerfile: Inlined the installation commands directly instead of copying the deleted
scripts/directory:cargo-componentandwkgvia cargodevcontainer.json: Updated the image reference from
ghcr.io/asw101/rust-wasi-hello-devcontainer:latesttoghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer:latestto match the workflow's published image path.Testing
publish-devcontainer.ymlworkflow manually viaworkflow_dispatchghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer