Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"image": "ghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer:latest",
"image": "ghcr.io/bytecodealliance/sample-wasi-http-rust/devcontainer:latest",
"features": {
//"ghcr.io/devcontainers/features/rust:1": {},
"ghcr.io/devcontainers/features/azure-cli:1": {}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-devcontainer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
# Defines two custom environment variables for the workflow. These are used for the Container registry domain, and a name for the Docker image that this workflow builds.
env:
REGISTRY: ghcr.io
IMAGE_NAME: ${{ github.repository }}-devcontainer
IMAGE_NAME: ${{ github.repository }}/devcontainer

# There is a single job in this workflow. It's configured to run on the latest available version of Ubuntu.
jobs:
Expand Down
21 changes: 21 additions & 0 deletions _/PR-50.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Fix the dev container publish step

## Summary

Fixes #50

The devcontainer publish workflow was failing because the Dockerfile referenced a `scripts/` directory that was removed in #26.

## Changes

- **Dockerfile**: Inlined the installation commands directly instead of copying the deleted `scripts/` directory:
- Install wasmtime via the official install script
- Install `cargo-component` and `wkg` via cargo

- **devcontainer.json**: Updated the image reference from `ghcr.io/asw101/rust-wasi-hello-devcontainer:latest` to `ghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer:latest` to match the workflow's published image path.

## Testing

- [ ] Trigger the `publish-devcontainer.yml` workflow manually via `workflow_dispatch`
- [ ] Verify the image builds and pushes successfully to `ghcr.io/bytecodealliance/sample-wasi-http-rust-devcontainer`
- [ ] Open the repository in a GitHub Codespace to confirm the devcontainer works