Skip to content

Update libm and simplify where it's used #12425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 3 commits into from
Feb 2, 2026
Merged

Update libm and simplify where it's used #12425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84a6e15
Update libm and simplify where it's used
the-ssd Jan 24, 2026
4b489b9
Remove TODO comment in round_ties_even function
the-ssd Jan 31, 2026
ce6f53a
Update vets
alexcrichton Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ rustc-hash = { version = "2.1.1", default-features = false }
libtest-mimic = "0.8.1"
semver = { version = "1.0.27", default-features = false }
ittapi = "0.4.0"
libm = "0.2.15"
libm = "0.2.16"
tokio-rustls = "0.25.0"
rustls = "0.22.0"
tokio-native-tls = "0.3.1"
Expand Down
20 changes: 1 addition & 19 deletions cranelift/codegen/src/ir/immediates.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,25 +704,7 @@ macro_rules! ieee_float {
/// Returns the nearest integer to `self`. Rounds half-way cases to the number
/// with an even least significant digit.
pub fn round_ties_even(self) -> Self {
// TODO: when libm v0.2.16 is published line below can be used instead
// Self::with_float(Libm::<$float_ty>::roundeven(self.$as_float()))
return Self::with_float(self.$as_float().roundeven());

trait Roundeven {
fn roundeven(self) -> Self;
}

impl Roundeven for f32 {
fn roundeven(self) -> Self {
libm::roundevenf(self)
}
}

impl Roundeven for f64 {
fn roundeven(self) -> Self {
libm::roundeven(self)
}
}
Self::with_float(Libm::<$float_ty>::roundeven(self.$as_float()))
}
)?
}
Expand Down
4 changes: 2 additions & 2 deletions supply-chain/imports.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,8 @@ user-id = 55123
user-login = "rust-lang-owner"

[[publisher.libm]]
version = "0.2.15"
when = "2025-05-06"
version = "0.2.16"
when = "2026-01-24"
user-id = 55123
user-login = "rust-lang-owner"

Expand Down