Fixes #12458 #12463
Merged
Fixes #12458 #12463
+155
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
495
to
499
| // Libraries like `Reqwest` generate a 0-length frame after sensing end-of-stream, | ||
| // so we have to check for the body's end-of-stream indicator here too | ||
| if self.body.is_end_stream() { | ||
| break 'result Ok(None); | ||
| } |
Member
There was a problem hiding this comment.
This looks like it should also be checking the size of the frame received because if it's a nonzero-sized-frame but the body has ended it seems like we'd still want to yield/copy that frame and then only on the next poll sever the stream when is_end_stream is true
Contributor
Author
There was a problem hiding this comment.
Fair point. I have updated the check and added an extra test. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasi-httpnot handling 0-length response frames #12458 and added test to validateStreamProducerimplementation forHostBodyStreamProviderhandles 0-length frames correctly