fix: ensure EntitySet::insert reserves correct capacity #12480
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisenokdonbassenok
requested review from
pchickey
and removed request for
a team
Member
|
Thanks! Could you add a test for this in this file? Ideally that'd be verified to fail before this PR but then pass after this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause:
wasmtime_environ::collections::EntitySet::insertcalledtry_ensure_capacity(k.index()), whileCompoundBitSet::try_ensure_capacityguarantees capacity only for indices < n. This could leave the backing bitset without space for k.index() and force a later infallible ensure_capacity inside insert, breaking the fallible-allocation contract and potentially panicking on OOM.Summary: Update
EntitySet::insertto reserve capacity for indices 0..=k.index() by callingtry_ensure_capacity(k.index() + 1)so that all allocations during insertion go through the fallible path and correctly report OutOfMemory instead of panicking.