Add runtime deprecation warnings for AbstractMigration and AbstractSeed #1006
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These classes have had @deprecated docblock annotations since 4.5.0, but no runtime warnings were emitted. This adds deprecationWarning() calls so users are notified during execution that they should migrate to BaseMigration and BaseSeed respectively.
Member
Author
|
@markstory I would recommend making the necessity to update early on to new Base classes more clear to consumers and plugin maintainers. We can release this also as a minor on 4.x if needed to clarify upgrade path. |
Member
I deleted my earlier comment after I thought a bit more. I think this is fine as is. We've had an upgrade path for a few minors already, and people on older core versions still have a path forward to no deprecations 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deprecationWarning()calls toAbstractMigrationandAbstractSeed@deprecated 4.5.0docblock annotations but no runtime warningsChanges
AbstractMigration: AddedsetAdapter()override with deprecation warning (constructor isfinalin Phinx)AbstractSeed: Added constructor with deprecation warningThis helps users migrate to
BaseMigrationandBaseSeedbefore the 5.0 release.