Fix dump command error when migrations directory does not exist #1009
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running migrations on a plugin without a migrations directory, the DumpCommand would fail with a file_put_contents error. Now it gracefully skips the dump with a verbose message instead. Fixes #1008
Contributor
|
Can confirm this fixes my bug |
LordSimal
approved these changes
Jan 27, 2026
Member
Author
|
I targeted 4.x now, should this go into 5.x instead? |
Contributor
|
well i use 5.x, but I believe this was also the case for 4.x |
Member
Author
|
I will merge it upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
migrations migrate -p SomePluginon a plugin without aconfig/Migrations/directory, theDumpCommandwould fail with afile_put_contentserrorDumpCommandchecks if the migration path directory exists before attempting to write the lock file, and gracefully returns success with a verbose info messageFixes #1008