Remove hardcoded default collation for MySQL tables #1011
Merged
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let MySQL/MariaDB use the database default collation instead of forcing utf8mb4_unicode_ci on every table. This avoids collation mismatches on servers with different defaults (e.g. MariaDB 11.8 uses utf8mb4_uca1400_ai_ci). Users who need a specific collation can still set it explicitly in their migrations. Fixes #1010
Allow configuring a global default collation for MySQL tables via
Configure::read('Migrations.default_collation'). When null (default),
tables inherit the database server collation. Per-table collation
options still take precedence.
dereuromark
force-pushed
the
fix/mysql-default-collation
branch
from
2056154 to
4b10cb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
utf8mb4_unicode_cidefault collation fromMysqlAdapter::createTable()Migrations.default_collationconfig option to allow setting a global default collation for all tablescollationentry in docs and update to reflect the new behaviorThis avoids collation mismatches on servers with different defaults (e.g. MariaDB 11.8 defaults to
utf8mb4_uca1400_ai_ci).Configuration
Per-table
'collation' => '...'options still take precedence over the global config.Fixes #1010