Add fixed option for binary column type #1014
Draft
+172
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the `fixed` attribute on binary columns to distinguish between fixed-length BINARY and variable-length VARBINARY types. This mirrors cakephp/cakephp#19207.
Tests cover: - Column class getter/setter for fixed option - Column::toArray() including fixed in output - Column::setOptions() accepting fixed option - MigrationHelper::getColumnOption() including/excluding fixed - MysqlAdapter creating BINARY vs VARBINARY based on fixed option
markstory
reviewed
Jan 29, 2026
Comment on lines
+788
to
+793
| public function setFixed(bool $fixed) | ||
| { | ||
| $this->fixed = $fixed; | ||
|
|
||
| return $this; | ||
| } |
Member
There was a problem hiding this comment.
We should eventually raise the version constraint so that we can remove this.
Member
Author
There was a problem hiding this comment.
Should we add a TODO here in code? Or just track this for a future cleanup in some ticket?
Comment on lines
3529
to
3532
| $this->assertNotNull($hashCol); | ||
| $this->assertNotNull($dataCol); | ||
| $this->assertTrue($hashCol->getFixed()); | ||
| $this->assertNull($dataCol->getFixed()); |
Member
There was a problem hiding this comment.
Should we also have an assertion on the column types?
Member
Author
|
We need to wait with final merge and bugfix release until core patch has been released it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixedattribute on binary columns to distinguish between fixed-lengthBINARYand variable-lengthVARBINARYtypesBINARY(n)column from the database,fixed => trueis now passed through to the Column objectfixedoption is now included in the generated migration codeThis is the companion PR to cakephp/cakephp#19207 which adds the core framework support for this feature.
Usage
Refs #999
Constraint: This one doesnt technically need one.
Also, even if, since #1013 is raising the constraint already, I skipped it for this PR here.