fix: nested text styling not inheriting from parent#4356
fix: nested text styling not inheriting from parent#4356rayan1810 wants to merge 6 commits intocallstack:mainfrom
Conversation
|
Hey @rayan1810, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
rayan1810
changed the title
|
Ready for Review ✅ |
rayan1810
changed the title
lukewalczak
force-pushed
the
main
branch
6 times, most recently
from
1062366 to
1da5d15
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| children.type === AnimatedText || | ||
| children.type === StyledText) | ||
| ) { | ||
| const { props } = rest.children as { |
There was a problem hiding this comment.
Bug: Undefined children in Props Destructuring
Line 110 incorrectly references rest.children when attempting to extract props. Since children was destructured from the component's props, rest.children is undefined, leading to an issue when accessing its properties.
| > | ||
| {children} | ||
| </NativeText> | ||
| </TextContext.Provider> |
There was a problem hiding this comment.
Bug: Text Context Missing in V3 Theme Variants
The TextContext.Provider is only present in the else branch, not in the theme.isV3 variant branch. This inconsistency prevents nested Text components from inheriting parent styles when using V3 themes with variants.
3 participants
This addresses the issue #4351 by adding a React Context with Text Component and checks + reads the parent Text's context to get it's style and merges it with the current Text's style, just like how React Native behaves.
Related issue
#4351
Test plan
Testing is pending, the PR is still a Work in progress!