-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add generate project + project improvements #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c386a0c
16f6e64
203ed4c
0766371
e84738f
03b1630
4d5da49
138fd49
1bf14ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| "ferric-cli": minor | ||
| --- | ||
|
|
||
| - Created generate command to generate scaffold project. Replacing ferric-example. | ||
| - Add path as arg to build project. | ||
| - Fixed cargo build command with correct --release flag. | ||
| - Added Cargo.toml optmizations for size. | ||
| - Added tests ferric-cli, to build and generate commands. | ||
| - Added debug flag as commands logging. | ||
| - Replaced eslint since the project lacks formatter and sort organizer, biome is faster and has all three. | ||
| - Changed build output to send to dist folder. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| module.exports = { | ||
| presets: ['module:@react-native/babel-preset'], | ||
| presets: ["module:@react-native/babel-preset"], | ||
| // plugins: [['module:react-native-node-api/babel-plugin', { stripPathSuffix: true }]], | ||
| plugins: ['module:react-native-node-api/babel-plugin'], | ||
| plugins: ["module:react-native-node-api/babel-plugin"], | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.1.2/schema.json", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Iff we'd switch linter, it would have to be in a completely separate PR without any added features, and we'd have to bike-shed that for a while on Discord first.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason why? Because even though Biome is newer, it has already found many lint issues that eslint didnt and fixed them or provided suggestions to the ones it didnt. Project is cleaner with it. It's just a tool that is and can do more than eslint was doing, not sure why there would be fuss in a project in a migration to it. But I understand it's your company project.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I added a few comments here or there, but I won't be able to give a thorough review if your actual changes are interleaved with a ton of changes from replacing the linter.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it's better to close the PR then?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't want to discourage you by blatantly closing the PR - I'll let you decide its faith. I would love to discuss and merge many of the improvements, if we're able to get them reviewed one-by-one 👍 |
||
| "assist": { | ||
| "actions": { | ||
| "source": { | ||
| "organizeImports": "on" | ||
| } | ||
| }, | ||
| "enabled": true | ||
| }, | ||
| "files": { | ||
| "ignoreUnknown": false, | ||
| "includes": [ | ||
| "**", | ||
| "!node_modules", | ||
| "!.nx/**", | ||
| "!**/dist/**", | ||
| "!apps/test-app/ios/**", | ||
| "!packages/host/hermes/**", | ||
| "!packages/node-addon-examples/examples/**" | ||
| ] | ||
| }, | ||
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "space" | ||
| }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true | ||
| } | ||
| }, | ||
| "vcs": { | ||
| "clientKind": "git", | ||
| "enabled": false, | ||
| "useIgnoreFile": false | ||
| } | ||
| } | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.